Avoid performing non trivial operations on files#7904
Closed
facchinm wants to merge 1 commit intoarduino:masterfrom
Closed
Avoid performing non trivial operations on files#7904facchinm wants to merge 1 commit intoarduino:masterfrom
facchinm wants to merge 1 commit intoarduino:masterfrom
Conversation
Fixes arduino#6404 as per @cmaglie comment.
Contributor
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7904-BUILD-752-linux32.tar.xz ℹ️ The |
Collaborator
|
Uhm, I'm a bit confused:
|
Member
Author
|
Argh, I was a bit in a hurry and pasted the wrong link... |
facchinm
added a commit
to facchinm/Arduino
that referenced
this pull request
Aug 22, 2018
Alternative to arduino#7904, tries to distinguish between * click on a single ino file downloaded from the internet (old behaviour applies, directory is created an the file is moved in it) * click on an ino file that for some reason is part of a project with the wrong name (eg. it was downloaded as zip from github, so the containing folder names becomes "projectName-master"). In this case if the directory is created one level above the selected file, all files are moved there and the original directory is recursively deleted)
facchinm
added a commit
to facchinm/Arduino
that referenced
this pull request
Aug 22, 2018
Alternative to arduino#7904, tries to distinguish between * click on a single ino file downloaded from the internet (old behaviour applies, directory is created an the file is moved in it) * click on an ino file that for some reason is part of a project with the wrong name (eg. it was downloaded as zip from github, so the containing folder names becomes "projectName-master"). In this case if the directory is created one level above the selected file, all files are moved there and the original directory is recursively deleted)
Member
|
Follow up on #7909 |
per1234
added
Component: IDE
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7843 as per @cmaglie comment.
Translations should be updated removing the second part of the information text.
RATIONALE:
Problem: most of the times .ino files downloads from the web are being saved in the Download folder, so the move operation copied the whole Downloads content into that folder 😳
@cmaglie suggested the IDE shouldn't be allowed to do this kind of operations; this patch removes the automatic move and requires the user to create the folder and move .ino file inside it manually